Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: IDE-24 Disable Tracking via Segment and Amplitude for NON-MT-US … #469

Merged
merged 5 commits into from
Feb 5, 2024

Conversation

acke
Copy link
Contributor

@acke acke commented Feb 2, 2024

…customers

Description

Provide description of this PR and changes, if linked Jira ticket doesn't cover it in full.

Checklist

  • Tests added and all succeed
  • Linted
  • CHANGELOG.md updated

Screenshots / GIFs

Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!

https://snyksec.atlassian.net/browse/IDE-24

@acke acke requested a review from a team as a code owner February 2, 2024 12:08
assertTrue(needsSnykToken(uri))
uri = "https://app.au.snyk.io/api"
assertTrue(needsSnykToken(uri))
val uris = listOf(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice refactor!

Copy link
Collaborator

@bastiandoetsch bastiandoetsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one. Only a minor linter thingy to fix. Approved 🎉

@acke acke merged commit 3155d36 into master Feb 5, 2024
8 checks passed
@acke acke deleted the feat/disable-tracking-for-NON-MT-US-customers branch February 5, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants