Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove kotlin specific code that could fail in non-kotlin IDEs #466

Merged
merged 3 commits into from
Jan 17, 2024

Conversation

bastiandoetsch
Copy link
Collaborator

Description

The plugin code was using some code that was IJ/Kotlin specific. This PR removes it.

Checklist

  • Tests added and all succeed
  • Linted
  • CHANGELOG.md updated
  • README.md updated, if user-facing

Screenshots / GIFs

Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!

@bastiandoetsch bastiandoetsch requested a review from a team as a code owner January 16, 2024 16:48
@bastiandoetsch bastiandoetsch changed the title fix/remove-idea-kotlin-lib-functions fix: remove kotlin specific code that could fail in non-kotlin IDEs Jan 16, 2024
Copy link
Contributor

@acke acke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@bastiandoetsch bastiandoetsch merged commit e363e9c into master Jan 17, 2024
8 checks passed
@bastiandoetsch bastiandoetsch deleted the fix/remove-idea-kotlin-lib-functions branch January 17, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants