Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adjust to changed analytics interface [HEAD-921] #459

Merged

Conversation

bastiandoetsch
Copy link
Collaborator

Description

This PR changes the client side of the analytics to:

  • change deviceId to device_id
  • sync os and arch values to the ones used in LS and in VS

Checklist

  • Tests added and all succeed
  • Linted
  • CHANGELOG.md updated
  • README.md updated, if user-facing

Screenshots / GIFs

Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!

@bastiandoetsch bastiandoetsch requested a review from a team as a code owner November 22, 2023 13:27
@bastiandoetsch bastiandoetsch force-pushed the feat/HEAD-921_adjust-to-changed-analytics-interface branch from e803314 to b21d804 Compare November 22, 2023 13:40
@bastiandoetsch bastiandoetsch force-pushed the feat/HEAD-921_adjust-to-changed-analytics-interface branch from b21d804 to f5dd87a Compare November 22, 2023 13:42
@bastiandoetsch bastiandoetsch enabled auto-merge (squash) November 23, 2023 10:36
@bastiandoetsch bastiandoetsch merged commit cbc8a96 into master Nov 23, 2023
8 checks passed
@bastiandoetsch bastiandoetsch deleted the feat/HEAD-921_adjust-to-changed-analytics-interface branch November 23, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants