feat: download arm64 CLI on M1/M2 macs, allow baseURL configuration [HEAD-867] #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterSchafer
reviewed
Oct 5, 2023
| @@ -463,6 +465,15 @@ class SnykSettingsDialog( | |||
| ) | |||
| ) | |||
|
|
|||
| cliBaseDownloadUrlTextField.toolTipText = "The default URL is https://static.snyk.io. " + | |||
There was a problem hiding this comment.
question: do we really want to mention this here? From a maintenance perspective, I think it would be better to leave this to the user-docs.
PeterSchafer
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the new arm64 binary for the CLI download. Also, it allows to add the baseURL to download the CLI from, to faciliate usage of FIPS enabled binaries, or locally provided CLIs.
Checklist
Screenshots / GIFs