-
Notifications
You must be signed in to change notification settings - Fork 21
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: scanning lock due of unresolved deps
- Renamed snykConf to projectConfigs, to improve the readability - Created configsSuccessfullyResolved method that confirms if configs sets as canBeResolved=true, can be really resolved or not. If there is an error now, while resolving configs set as canBeResolved=true, we are no longer blocking the scanning. We ignore those configs whose depGraph cannot be computed and move forward with the scanning process since it's not a snyk issue but a given gradle project resolution config caused by bad config or 3rd party gradle dependencies bad behaving. By going into `test/fixtures/successful-scan-with-unresolved-custom-configs/build.gradle` and running `gradle -q dependencies` you will see the following message (pic below) This fixture emulates issue gradle/gradle#6854, **where gradle cannot resolve incremental analysis configurations**. <img width="638" alt="Screen Shot 2021-01-31 at 18 54 04" src="https://user-images.githubusercontent.com/40601533/106393164-d369dd80-63f5-11eb-9335-bcc1716b890a.png"> What does **FAILED** means? Means any dependency belonging to these configuratios failed to be resolved (compute depGraph) Continue reading about failed resolution in Gradle Docs.. https://docs.gradle.org/current/userguide/viewing_debugging_dependencies.html#example_rendering_the_dependency_report_for_a_custom_configuration
- Loading branch information
Showing
5 changed files
with
1,022 additions
and
26 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletions
16
test/fixtures/successful-scan-with-unresolved-custom-configs/build.gradle
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
plugins { | ||
id 'io.gatling.gradle' version "3.5.0" | ||
} | ||
|
||
build.dependsOn gatlingClasses | ||
|
||
dependencies { | ||
gatling group: 'org.scalaj', name: 'scalaj-http_2.13', version: '2.4.2' | ||
} | ||
|
||
gatling { | ||
simulations = { | ||
exclude "**/paxos/BaseSimulation.scala" | ||
exclude "**/paxos/Configuration.scala" | ||
} | ||
} |
Oops, something went wrong.