feat: add login button to plugin welcome page [IDE-798] #248
+60
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… some rendering issues on smaller screens.
andrewrobinsonhodges-snyk
force-pushed
the
feat/add-login-button
branch
from
d26ac76 to
54e1f11
Compare
andrewrobinsonhodges-snyk
changed the title
| snyk.trust.dialog.warning.text=When scanning project files for vulnerabilities, Snyk may automatically execute code such as invoking the package manager to get dependency information.<br><br>You should only scan projects you trust.<br><br> | ||
|
|
||
|
|
||
| snyk.panel.auth.trust.warning.text=When scanning project files, Snyk may automatically execute code such as invoking the package manager to get dependency information.<br/>You should only scan projects you trust. <a href="https://docs.snyk.io/ide-tools/jetbrains-plugins/folder-trust">More info</a> |
There was a problem hiding this comment.
The jetbrains link does not look right :)
Comment on lines
+73
to
+78
| SnykWizard wizard = new SnykWizard(); | ||
| WizardDialog dialog = new WizardDialog(Display.getDefault().getActiveShell(),wizard); | ||
|
|
||
| dialog.setBlockOnOpen(true); | ||
| dialog.open(); | ||
| return null; |
There was a problem hiding this comment.
suggestion: don't duplicate the code, but move SnykExtendedLanguageClient.runSnykWizard() to a central place and use it from all places where the Wizard is launched.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a "Trust project and scan" button to the Eclipse plugin Welcome Panel, which launches the Authentication Wizard.
Also tidied up the HTML (fixing the indentation) and spacing to closer match the layout and behaviour of the equivalent panel in the IntelliJ plugin.
Note that we might commonise the HTML between the plugins in the future, so I deliberately avoided changing how the HTML is constructed for now.
Checklist
Screenshots / GIFs