Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increasing memory allocation #93

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dehvCurtis
Copy link

increased default memory allocation values in the snyk broker, 256Mi is not sufficient.

increased default memory allocation values in the snyk broker, 256Mi is not sufficient.
@dehvCurtis dehvCurtis requested a review from a team as a code owner November 22, 2023 17:36
@CLAassistant
Copy link

CLAassistant commented Nov 22, 2023

CLA assistant check
All committers have signed the CLA.

@aarlaud
Copy link
Contributor

aarlaud commented Nov 24, 2023

I read this again, delete my previous response. I'm not sure I can push this to 1G without having following complaints for existing users, but I'm curious to know what motivated that PR specifically.
What did you observe specifically? If you can elaborate on your setup, single broker, HA mode, etc

thanks

@dehvCurtis
Copy link
Author

Hello @aarlaud thanks so much for your response. I am on a single broker (wasn't aware that Snyk offered HA :) ), I'm experiencing inconsistent restarts with nothing in logs or events. when looking at it and comparing to other similar applications on clusters I manage, I determined 256Mi was a bit low for Enterprise and that could be the cause. After upping my env, I was able to resolve the issue.

@dehvCurtis
Copy link
Author

dehvCurtis commented May 3, 2024

@aarlaud after we spoke, i lowered my specs down to 256MB again and began to experience resource issues once again, such as delayed page loading, delayed cloning, etc. please keep in mind this is a burstable configuration, so existing users are allocating 1GB, they burst to 1GB based on conditions. Currently, the chart is locked as "guaranteed" QoS.

https://github.com/snyk/snyk-broker-helm/blob/main/charts/snyk-broker/values.yaml#L266C1-L273C21

Let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants