Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: configure broker client service url #87

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Conversation

iuliams
Copy link
Contributor

@iuliams iuliams commented Oct 26, 2023

Currently, the customer has to specify the name of the broker service. But for CRA this is not needed, since they are running in the same cluster and it's always known.

@iuliams iuliams self-assigned this Oct 26, 2023
@iuliams iuliams force-pushed the fix/cra-broker-client-url branch 2 times, most recently from f232aa2 to 5d30452 Compare October 27, 2023 12:56
Signed-off-by: iuliams <[email protected]>
Signed-off-by: Iulia Manda <[email protected]>
@iuliams iuliams force-pushed the fix/cra-broker-client-url branch from 5d30452 to 09cca1a Compare October 27, 2023 12:59
@iuliams iuliams marked this pull request as ready for review October 27, 2023 13:00
@iuliams iuliams requested a review from a team as a code owner October 27, 2023 13:00
Copy link
Contributor

@pavel-snyk pavel-snyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@iuliams iuliams merged commit 140a004 into main Oct 27, 2023
2 checks passed
@iuliams iuliams deleted the fix/cra-broker-client-url branch October 27, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants