Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cacertfile to load cacert more easily #77

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

aarlaud
Copy link
Contributor

@aarlaud aarlaud commented Sep 5, 2023

What this does

Adding caCertFile option to pass ca certs directly from the local file system instead of having the file requiring to be in the charts folder, making it annoying to have to download the charts etc.

caCert option remains but it hard to use, the following does not work:

helm install snyk-broker-chart snyk-broker/snyk-broker --set caCert=certificate.crt \
             --set scmType=github-com \
             --set brokerToken=123das \
             --set scmToken=123dsa \
             --set brokerClientUrl=123fsdd:0000 \
             -n snyk-broker --create-namespace

It requires the certificate.crt to be in the charts folder, which can work in some cases if you have the chart locally.

Adding caCertFile option taking the ca cert inline thanks for the set-file option:

helm install snyk-broker-chart snyk-broker/snyk-broker --set-file caCertFile=your/machine/path/to/certificate.crt \
             --set scmType=github-com \
             --set brokerToken=123das \
             --set scmToken=123dsa \
             --set brokerClientUrl=123fsdd:0000 \
             -n snyk-broker --create-namespace

It then doesn't require the certificate to be in the chart and is instead passed inline as value and added to the configmap via value instead of Files.Globs templating inside the configmap.

@aarlaud aarlaud requested a review from a team as a code owner September 5, 2023 21:30
@aarlaud aarlaud force-pushed the feat/add-cacertfile-easy-loading-from-file branch from 38d62be to f0cbd00 Compare September 5, 2023 21:32
Copy link
Contributor

@pavel-snyk pavel-snyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aarlaud aarlaud merged commit a418d27 into main Sep 6, 2023
@aarlaud aarlaud deleted the feat/add-cacertfile-easy-loading-from-file branch September 6, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants