Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate certificate format [HYB-591] #130

Merged
merged 3 commits into from
Aug 15, 2024

Conversation

soniqua
Copy link
Contributor

@soniqua soniqua commented Aug 15, 2024

What

  • Expect certificates provided as values to have -----BEGIN CERTIFICATE----- as header, and -----END CERTIFICATE----- as footer

Why

  • We do not expect any private key material, nor do we support certificates in other formats

@soniqua soniqua requested a review from a team as a code owner August 15, 2024 09:59
@soniqua soniqua force-pushed the fix/validate-certificate-format branch from a50808b to a3d6b7f Compare August 15, 2024 13:04
@soniqua soniqua merged commit f0da331 into main Aug 15, 2024
4 checks passed
@soniqua soniqua deleted the fix/validate-certificate-format branch August 15, 2024 13:04
@soniqua soniqua changed the title fix: validate certificate format fix: validate certificate format [HYB-591] Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants