Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly set tlsRejectUnauthorized #129

Merged
merged 3 commits into from
Aug 22, 2024
Merged

fix: correctly set tlsRejectUnauthorized #129

merged 3 commits into from
Aug 22, 2024

Conversation

soniqua
Copy link
Contributor

@soniqua soniqua commented Aug 15, 2024 •
edited
Loading

What

  • Handle cases where tlsRejectUnauthorized is set to false (boolean) or "0" (string)

Why

  • Previously setting this value to false has no effect
  • Passing "0" via --set causes Helm to cast "0" as 0, which has fails input validation

@soniqua soniqua marked this pull request as ready for review August 15, 2024 09:37
@soniqua soniqua requested review from a team as code owners August 15, 2024 09:37
@soniqua soniqua requested a review from iuliams August 15, 2024 09:37
@soniqua soniqua force-pushed the fix/correctly-set-tls-reject-unauthorized branch from 5b883b5 to 4c4a51f Compare August 16, 2024 09:57
@soniqua soniqua merged commit 9fa0f0e into main Aug 22, 2024
4 checks passed
@soniqua soniqua deleted the fix/correctly-set-tls-reject-unauthorized branch August 22, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saumilmac saumilmac saumilmac approved these changes

@popas90 popas90 popas90 approved these changes

@iuliams iuliams Awaiting requested review from iuliams iuliams was automatically assigned from snyk/container-integration

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soniqua @popas90 @saumilmac