Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adds labels to broker deployment [HYB-560] #120

Merged
merged 10 commits into from
Jun 27, 2024
Merged

fix: adds labels to broker deployment [HYB-560] #120

merged 10 commits into from
Jun 27, 2024

Conversation

saumilmac
Copy link
Contributor

What:

  • Adds additional labels to snyk-broker-deployment

@saumilmac saumilmac requested a review from a team as a code owner June 19, 2024 18:12
@saumilmac saumilmac changed the title fix: adds labels to broker deployment fix: adds labels to broker deployment[HYB-560] Jun 19, 2024
soniqua
soniqua requested changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@soniqua soniqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests to validate this new functionality

@saumilmac saumilmac requested review from soniqua and a team June 20, 2024 13:34
@saumilmac saumilmac force-pushed the fix/adds-labels-to-deployment branch from 2ef9751 to 694f1b0 Compare June 24, 2024 16:37
@saumilmac saumilmac requested a review from soniqua June 24, 2024 16:38
aarlaud
aarlaud previously approved these changes Jun 24, 2024
View reviewed changes
@saumilmac saumilmac requested review from soniqua and aarlaud June 25, 2024 11:43
@soniqua soniqua changed the title fix: adds labels to broker deployment[HYB-560] fix: adds labels to broker deployment [HYB-560] Jun 25, 2024
@saumilmac saumilmac requested a review from soniqua June 25, 2024 15:51
@saumilmac saumilmac closed this Jun 25, 2024
@saumilmac saumilmac reopened this Jun 25, 2024
@saumilmac saumilmac closed this Jun 26, 2024
@saumilmac saumilmac reopened this Jun 26, 2024
@saumilmac saumilmac merged commit 06105f3 into main Jun 27, 2024
4 checks passed
@saumilmac saumilmac deleted the fix/adds-labels-to-deployment branch June 27, 2024 16:06
@soniqua soniqua linked an issue Jun 28, 2024 that may be closed by this pull request
Allow to add labels to Deployment #119
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soniqua soniqua soniqua approved these changes

@aarlaud aarlaud Awaiting requested review from aarlaud

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow to add labels to Deployment
3 participants
@saumilmac @aarlaud @soniqua