Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adding https scheme for liveness and readiness probe[HYB-475] #109

Merged
merged 3 commits into from
Mar 13, 2024
Merged

fix: adding https scheme for liveness and readiness probe[HYB-475] #109

merged 3 commits into from
Mar 13, 2024

Conversation

saumilmac
Copy link
Contributor

@saumilmac saumilmac commented Mar 13, 2024 •
edited
Loading

What:

  • Adding HTTPS scheme for Liveness and Readiness prob when TLS certs are defined.

Why:

  • liveness probe and readiness probe are not configured to use HTTPS in current broker deployment

@saumilmac saumilmac requested a review from a team as a code owner March 13, 2024 15:45
@saumilmac saumilmac changed the title fix: adding https scheme for liveness and readiness probe fix: adding https scheme for liveness and readiness probe[HYB-475] Mar 13, 2024
@saumilmac saumilmac merged commit c5af52e into main Mar 13, 2024
4 checks passed
@saumilmac saumilmac deleted the fix/add-https-for-liveness-probe branch March 13, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarlaud aarlaud aarlaud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saumilmac @aarlaud