Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deep traversal of CycloneDX components #60

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

paulrosca-snyk
Copy link
Contributor

Implement deep component traversal when enriching CycloneDX SBOMs.

internal/utils/cdx.go Outdated Show resolved Hide resolved
internal/utils/cdx.go Show resolved Hide resolved
@paulrosca-snyk paulrosca-snyk force-pushed the feat/cyclonedx-deep-comp-traversal branch from c7c25f7 to 566d3bc Compare February 29, 2024 13:29
@paulrosca-snyk paulrosca-snyk marked this pull request as ready for review February 29, 2024 13:40
@paulrosca-snyk paulrosca-snyk requested review from garethr and a team as code owners February 29, 2024 13:40
Copy link
Collaborator

@mcombuechen mcombuechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

feat: improve discoverComps readability and test coverage
@paulrosca-snyk paulrosca-snyk force-pushed the feat/cyclonedx-deep-comp-traversal branch from 566d3bc to 0a23db4 Compare February 29, 2024 13:54
@mcombuechen mcombuechen linked an issue Feb 29, 2024 that may be closed by this pull request
@mcombuechen mcombuechen changed the title Feat/cyclonedx deep comp traversal fix: depp traversal of CycleDX components Feb 29, 2024
@mcombuechen mcombuechen changed the title fix: depp traversal of CycleDX components fix: deep traversal of CycleDX components Feb 29, 2024
@mcombuechen mcombuechen changed the title fix: deep traversal of CycleDX components fix: deep traversal of CycloneDX components Feb 29, 2024
@mcombuechen mcombuechen merged commit af7b7a7 into main Mar 1, 2024
5 checks passed
@mcombuechen mcombuechen deleted the feat/cyclonedx-deep-comp-traversal branch March 1, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No enrichment for nested components in CycloneDX
2 participants