feat: support severity threshold #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
thisislawatts
commented
May 6, 2024
thisislawatts
commented
- refactor: rename to remove typo
- feat: filter findings output to remove items outside of target severity
- fix: load severity-threshold from configuration
- feat: filter output by supplied severity threshold
thisislawatts
commented
May 6, 2024
thisislawatts
commented
May 6, 2024
| if !satisfyMinLevel { | ||
| openIssueLabelledCount += renderInSeverityColor(severity, fmt.Sprintf(" %d %s ", 0, strings.ToUpper(severity))) | ||
| ignoredIssueLabelledCount += renderInSeverityColor(severity, fmt.Sprintf(" %d %s ", 0, strings.ToUpper(severity))) | ||
| continue |
There was a problem hiding this comment.
question: Design decision will be needed on whether we want to show 0 LOW when in fact there were Low Issues but they have been filtered out by --severity-threshold setting.
CLI-304
thisislawatts
force-pushed
the
feat/support-severity-threshold-filter
branch
from
1d67ff4 to
94f9262
Compare
|
Following a review session earlier today with @PeterSchafer we agreed to refactoring snyk/cli#5220, into GAF. |
PeterSchafer
reviewed
May 8, 2024
PeterSchafer
approved these changes
May 8, 2024
thisislawatts
commented
May 8, 2024
| } | ||
|
|
||
| return reversed | ||
| return original | ||
| } |
There was a problem hiding this comment.
praise: Nice optimisation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.