Merge pull request #224 from snyk/fix/upgrade-needle

fix: upgrade needle and disable proxy in needle
snyk · Dec 19, 2023 · c982553 · c982553
2 parents a777917 + 8947705
commit c982553
Show file tree

Hide file tree

Showing 3 changed files with 37 additions and 25 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -51,7 +51,7 @@
   },
   "devDependencies": {
     "@types/jest": "^26.0.12",
-    "@types/needle": "^2.5.2",
+    "@types/needle": "^3.3.0",
     "@types/node": "^14.6.2",
     "@types/write": "^2.0.1",
     "@typescript-eslint/eslint-plugin": "^4.31.2",
@@ -86,7 +86,7 @@
     "lodash.pick": "^4.4.0",
     "lodash.union": "^4.6.0",
     "multimatch": "^5.0.0",
-    "needle": "3.0.0",
+    "needle": "^3.3.0",
     "p-map": "^3.0.0",
     "uuid": "^8.3.2",
     "yaml": "^1.10.2"

diff --git a/src/needle.ts b/src/needle.ts
@@ -80,6 +80,7 @@ export async function makeRequest<T = void>(
   }
 
   const options: needle.NeedleOptions = {
+    use_proxy_from_env_var: false,
     headers: payload.headers,
     open_timeout: TIMEOUT_DEFAULT, // No timeout
     response_timeout: payload.timeout || TIMEOUT_DEFAULT,