Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(auth): auto detect API Url during OAuth authentication #5601

Merged
merged 1 commit into from
Dec 2, 2024
Merged

feat(auth): auto detect API Url during OAuth authentication #5601

merged 1 commit into from
Dec 2, 2024

Conversation

thisislawatts
Copy link
Member

@thisislawatts thisislawatts commented Nov 26, 2024 •
edited
Loading

Pull Request Submission Checklist

  • Follows CONTRIBUTING guidelines
  • Includes detailed description of changes
  • Contains risk assessment (Low | Medium | High)
  • Highlights breaking API changes (if applicable)
  • Links to automated tests covering new functionality
  • Includes manual testing instructions (if necessary)
  • Updates relevant GitBook documentation (PR link: ___)

What does this PR do?

Where should the reviewer start?

How should this be manually tested?

  • Build the CLI (or download artefact from CI)
  • Remove auth material
    • snyk config unset api
    • snyk config unset INTERNAL_OAUTH_TOKEN_STORAGE
  • Run against dev snyk config set endpoint=https://api.dev.snyk.io
  • Run auth command~/snyk/cli/binary-releases/snyk-macos auth -d

@thisislawatts thisislawatts force-pushed the feat/use-instance-param branch from 58d7b48 to d95daf3 Compare November 26, 2024 18:17
@thisislawatts thisislawatts marked this pull request as ready for review November 27, 2024 20:52
@thisislawatts thisislawatts requested a review from a team as a code owner November 27, 2024 20:52
@PeterSchafer PeterSchafer force-pushed the feat/use-instance-param branch from d95daf3 to d079554 Compare November 28, 2024 15:22
@PeterSchafer PeterSchafer reopened this Nov 28, 2024
@thisislawatts thisislawatts force-pushed the feat/use-instance-param branch from a7f397a to 99a868a Compare November 29, 2024 10:38
@PeterSchafer PeterSchafer force-pushed the feat/use-instance-param branch 2 times, most recently from 8dbe952 to 70617c1 Compare November 29, 2024 16:27
@PeterSchafer PeterSchafer changed the title feat: use instance param to determine oauth2 token endpoint feat(auth): auto detect API Url during OAuth authentication Nov 29, 2024
@PeterSchafer PeterSchafer force-pushed the feat/use-instance-param branch 2 times, most recently from 907668d to 7c06390 Compare November 29, 2024 16:39
@thisislawatts thisislawatts force-pushed the feat/use-instance-param branch from d9e8708 to b3b363b Compare December 2, 2024 11:46
@j-luong j-luong force-pushed the feat/use-instance-param branch from 8ecd445 to 791060f Compare December 2, 2024 12:33
@j-luong j-luong force-pushed the feat/use-instance-param branch from 791060f to 6884511 Compare December 2, 2024 12:35
@j-luong j-luong enabled auto-merge December 2, 2024 12:37
@j-luong j-luong merged commit 19416fa into main Dec 2, 2024
7 checks passed
@j-luong j-luong deleted the feat/use-instance-param branch December 2, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterSchafer PeterSchafer PeterSchafer approved these changes

@j-luong j-luong j-luong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thisislawatts @j-luong @PeterSchafer