fix: extra error handling and debugging [IAC-3138]

[sergiu-snyk]

Pull Request Submission Checklist

• Follows CONTRIBUTING guidelines
• Includes detailed description of changes
• Contains risk assessment (Low | Medium | High)
• Highlights breaking API changes (if applicable)
• Links to automated tests covering new functionality
• Includes manual testing instructions (if necessary)
• Updates relevant GitBook documentation (PR link: ___)

What does this PR do?

Extra debug logging and potential fix for an error seen in a customer local IaC scan (no access to files): Cannot read properties of undefined (reading 'projectType')

This customer has a particularity in the scanned repo that we cannot reproduce locally.

We intend to give the customer a CLI preview version with these fixes and gather more information on what the problem is.

See more context from the ticket and the PR inline comments.

How should this be manually tested?

Can't be tested manually, it's an error we cannot reproduce.

What are the relevant tickets?

https://snyksec.atlassian.net/browse/IAC-3138

[github-actions]

	Warnings
⚠️	Since the CLI is unifying on a standard and improved tooling, we're starting to migrate old-style imports and exports to ES6 ones. A file you've modified is using either module.exports or require(). If you can, please update them to ES6 import syntax and export syntax. Files found: src/lib/snyk-test/iac-test-result.ts
⚠️	You've modified files in src/ directory, but haven't updated anything in test folder. Is there something that could be tested?

Generated by 🚫 dangerJS against 7fbae0f

[sergiu-snyk]

This is the main fix. The customer log attached to the Jira ticket indicates that an Error is returned in some cases from the policy engine (it should not) and, because the check was done only for CustomError, any Error was allowed to go on the happy path being treated as an actual result and crashing with undefined on prop checking.

This is a fix for a regression introduced here: 4d08086#diff-634d0df2f6eab15512d93b5a3ab1ada33e7146aecd9771844e6f4d503ef3f066L200

[sergiu-snyk]

This condition, where a result is not set, should never happen anymore if all errors are caught by the fix above. But if it still does, we log a user friendly message instead of letting it crash trying to access props for an inexistent result.

[sergiu-snyk]

You've modified files in src/ directory, but haven't updated anything in test folder. Is there something that could be tested?

Adding an unit test is very difficult for this legacy code, and its value would be minimal.
We could add an acceptance test, once we determine exactly what input to feed the scanner for reproducing the issue, but first we need to get a preview build to the customer and get more data.