Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop sending CLI args in analytics #5575

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Conversation

j-luong
Copy link
Contributor

@j-luong j-luong commented Nov 12, 2024

Pull Request Submission Checklist

  • Follows CONTRIBUTING guidelines
  • Includes detailed description of changes
  • Contains risk assessment (Low | Medium | High)
  • Highlights breaking API changes (if applicable)
  • Links to automated tests covering new functionality
  • Includes manual testing instructions (if necessary)
  • Updates relevant GitBook documentation (PR link: ___)

What does this PR do?

This PR updates GAF and the TypeScript CLI to stop sending CLI args to the analytics API

Where should the reviewer start?

  • make clean build
  • run any legacy snyk command with the debug flag
  • confirm the snyk analytics debug logs contain an empty [] args property

How should this be manually tested?

@j-luong j-luong requested a review from a team as a code owner November 12, 2024 16:06
Copy link
Contributor

github-actions bot commented Nov 12, 2024

Warnings
⚠️

Since the CLI is unifying on a standard and improved tooling, we're starting to migrate old-style imports and exports to ES6 ones.
A file you've modified is using either module.exports or require(). If you can, please update them to ES6 import syntax and export syntax.
Files found:

  • src/lib/analytics/index.ts

Generated by 🚫 dangerJS against 6d183fb

@j-luong j-luong force-pushed the fix/CLI-586_cliArgsInAnalytics branch 2 times, most recently from 3ea87bc to 47cc5e4 Compare November 13, 2024 13:18
@j-luong j-luong force-pushed the fix/CLI-586_cliArgsInAnalytics branch from 47cc5e4 to 6d183fb Compare November 13, 2024 13:20
@j-luong j-luong merged commit 8ef2e3e into main Nov 13, 2024
7 checks passed
@j-luong j-luong deleted the fix/CLI-586_cliArgsInAnalytics branch November 13, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants