Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(general): prevent snyk-policy lib from interrupting stdout to ensure valid --json --sarif output #5571

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

thisislawatts
Copy link
Member

@thisislawatts thisislawatts commented Nov 11, 2024

Pull Request Submission Checklist

  • Follows CONTRIBUTING guidelines
  • Includes detailed description of changes
  • Contains risk assessment (Low | Medium | High)
  • Highlights breaking API changes (if applicable)
  • Links to automated tests covering new functionality
  • Includes manual testing instructions (if necessary)
  • Updates relevant GitBook documentation (PR link: ___)

What does this PR do?

Updates snyk-policy library to remove logging messages from being emitted on stdout. This was breaking Snyk CLI commands where stdout is used to build JSON documents.

Copy link
Contributor

github-actions bot commented Nov 11, 2024

Warnings
⚠️

"fix(general): prevent snyk-policy lib from interrupting stdout to ensure valid --json --sarif output" is too long. Keep the first line of your commit message under 72 characters.

Generated by 🚫 dangerJS against 469edf5

@thisislawatts thisislawatts marked this pull request as ready for review November 11, 2024 10:58
@thisislawatts thisislawatts requested a review from a team as a code owner November 11, 2024 10:58
@thisislawatts thisislawatts force-pushed the fix/snyk-policy-breaking-stdout branch from ee34d6c to 469edf5 Compare November 11, 2024 12:53
@thisislawatts thisislawatts merged commit 3e990ac into main Nov 11, 2024
9 checks passed
@thisislawatts thisislawatts deleted the fix/snyk-policy-breaking-stdout branch November 11, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants