fix: do not treat warnings as errors on restore #5560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandor-trombitas
approved these changes
Nov 1, 2024
37IulianPopovici
deleted the
fix/do-not-treat-warnings-as-errors-on-restore
branch
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
What does this PR do?
Updates snyk-nuget-plugin to fix a bug regarding restoring dotnet projects that have turned on, and also adds a property named
SnykTestthat will be present when we rundotnet publish. The scope for this property is to allow customers to enable/disable properties that might interfere and break out scanning.Where should the reviewer start?
Looking over this PRs:
snyk/snyk-nuget-plugin#226
snyk/snyk-nuget-plugin#225
How should this be manually tested?
Using this fixtures:
Treat warnings as error issue
SnykTest property