fix: use proxy aware snyk-iac-test [INC-1647] #5557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiu-snyk
force-pushed
the
fix/INC-1647/use-proxy-aware-snyk-iac-test
branch
from
2028433 to
537cfd8
Compare
sergiu-snyk
commented
Oct 29, 2024
| @@ -284,7 +283,6 @@ async function spawn( | |||
| env: Record<string, string | undefined>, | |||
| ) { | |||
| return new Promise<SpawnResult>((resolve) => { | |||
| env = restoreEnvProxy(env); | |||
There was a problem hiding this comment.
restoring proxy env vars before spawning snyk-iac-test is no longer necessary
PeterSchafer
approved these changes
Oct 29, 2024
|
@sergiu-snyk looks good to me! But please do |
sergiu-snyk
force-pushed
the
fix/INC-1647/use-proxy-aware-snyk-iac-test
branch
from
0427c0d to
d5d1e2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
What does this PR do?
snyk iac testcommand was broken for IaC+ (FFiacIntegratedExperience) when usingsnyk auth, because thesnyk-iac-testbinary used Oauth token from env var (which was removed at some point) instead of directing the API calls through the internal proxy of the CLI (which handles auth)This PR upgrades to a new version of
snyk-iac-testthat uses the internal proxy for API calls.See https://github.com/snyk/snyk-iac-test/pull/256 for the changes done on the
snyk-iac-testside.How should this be manually tested?
Run
snyk iac testwith an org that hasiacIntegratedExperienceFF enabled, with Oauth2 or with token via env var.Run
snyk iac testwith an org that hasiacIntegratedExperienceFF disabled, with Oauth2 or with token via env var.What are the relevant tickets?
INC-1647
slack thread