Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(localfindings): add new filter workflow for local findings #5553

Merged
merged 1 commit into from
Nov 6, 2024
Merged

chore(localfindings): add new filter workflow for local findings #5553

merged 1 commit into from
Nov 6, 2024

Conversation

sandor-trombitas
Copy link
Contributor

@sandor-trombitas sandor-trombitas commented Oct 25, 2024 •
edited by thisislawatts
Loading

Pull Request Submission Checklist

  • Follows CONTRIBUTING guidelines
  • Includes detailed description of changes
  • Contains risk assessment (Low | Medium | High)
  • Highlights breaking API changes (if applicable)
  • Links to automated tests covering new functionality
  • Includes manual testing instructions (if necessary)
  • Updates relevant GitBook documentation (PR link: ___)

What does this PR do?

  • Bumps GAF to add a new filter workflow that filters a local findings model based on severity-threshold

Where should the reviewer start?

How should this be manually tested?

make build && INTERNAL_SNYK_TRANSFORMATION_WORKFLOW_ENABLED=true ./binary-releases/snyk-macos-arm64 code test --org=<org-slug> . --severity-threshold=medium

@sandor-trombitas sandor-trombitas requested a review from a team as a code owner October 25, 2024 11:36
j-luong
j-luong reviewed Oct 25, 2024
View reviewed changes
cliv2/cmd/cliv2/main.go Outdated Show resolved Hide resolved
PeterSchafer
PeterSchafer reviewed Oct 30, 2024
View reviewed changes
cliv2/go.sum Outdated Show resolved Hide resolved
@PeterSchafer
Copy link
Collaborator

Question: Aren't we missing the integration of the filter workflow?

@sandor-trombitas sandor-trombitas force-pushed the CLI-545-filter-workflow branch 8 times, most recently from 7f2feea to e603119 Compare November 1, 2024 14:22
thisislawatts
thisislawatts previously requested changes Nov 1, 2024
View reviewed changes
cliv2/cmd/cliv2/main_test.go Outdated Show resolved Hide resolved
@sandor-trombitas sandor-trombitas force-pushed the CLI-545-filter-workflow branch 3 times, most recently from 656a897 to a6ddd38 Compare November 4, 2024 09:17
@thisislawatts thisislawatts dismissed their stale review November 4, 2024 14:55

Tests have been updated

@sandor-trombitas sandor-trombitas force-pushed the CLI-545-filter-workflow branch 3 times, most recently from 1ef62cc to 0af32c3 Compare November 5, 2024 13:11
@thisislawatts thisislawatts changed the title feat(localfindings): add new filter workflow for local findings chore(localfindings): add new filter workflow for local findings Nov 5, 2024
@sandor-trombitas sandor-trombitas merged commit e7afb30 into main Nov 6, 2024
7 checks passed
@sandor-trombitas sandor-trombitas deleted the CLI-545-filter-workflow branch November 6, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterSchafer PeterSchafer PeterSchafer left review comments

@j-luong j-luong j-luong left review comments

@thisislawatts thisislawatts thisislawatts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sandor-trombitas @PeterSchafer @thisislawatts @j-luong