fix: manually configure supported env vars #5532
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
Risk Assessment - Medium
The existing behaviour, although not correct, may be used by clients without knowing that it's unintentional. This would lead to breaking changes for them. The fix for them would be to use the intended env var for their purpose.
What does this PR do?
This PR updates the CLI so that it no longer automatically detects supported env vars. The automatic detection led to bugs where ambiguous environment variables (e.g.
ORG
) would be picked up and used in the CLI.By explicitly configuring the supported env vars, we can avoid these sorts of bugs (e.g. by requiring namespace prefixes in env vars we want to support).
Where should the reviewer start?
Review the related GAF PR
How should this be manually tested?