Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: change binary download url #5475

Merged
merged 1 commit into from
Sep 9, 2024
Merged

feat: change binary download url #5475

merged 1 commit into from
Sep 9, 2024

Conversation

sandor-trombitas
Copy link
Contributor

Reverts #5431

@sandor-trombitas sandor-trombitas requested a review from a team as a code owner September 9, 2024 09:09
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024

Warnings
⚠️

Since the CLI is unifying on a standard and improved tooling, we're starting to migrate old-style imports and exports to ES6 ones.
A file you've modified is using either module.exports or require(). If you can, please update them to ES6 import syntax and export syntax.
Files found:

  • ts-binary-wrapper/src/common.ts

Generated by 🚫 dangerJS against badecb3

@j-luong j-luong enabled auto-merge September 9, 2024 09:27
@j-luong j-luong merged commit 0b4e721 into release-candidate Sep 9, 2024
6 checks passed
@j-luong j-luong deleted the revert-5431-revert-5369-CLI-415-binary-url branch September 9, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-luong j-luong j-luong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sandor-trombitas @j-luong