Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(GAF): bump gaf version #5470

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Conversation

j-luong
Copy link
Contributor

@j-luong j-luong commented Sep 5, 2024

Pull Request Submission

Please check the boxes once done.

The pull request must:

  • Reviewer Documentation
    • follow CONTRIBUTING rules
    • be accompanied by a detailed description of the changes
    • contain a risk assessment of the change (Low | Medium | High) with regards to breaking existing functionality. A change e.g. of an underlying language plugin can completely break the functionality for that language, but appearing as only a version change in the dependencies.
    • highlight breaking API if applicable
    • contain a link to the automatic tests that cover the updated functionality.
    • contain testing instructions in case that the reviewer wants to manual verify as well, to add to the manual testing done by the author.
    • link to the link to the PR for the User-facing documentation
  • User facing Documentation
    • update any relevant documentation in gitbook by submitting a gitbook PR, and including the PR link here
    • ensure that the message of the final single commit is descriptive and prefixed with either feat: or fix: , others might be used in rare occasions as well, if there is no need to document the changes in the release notes. The changes or fixes should be described in detail in the commit message for the changelog & release notes.
  • Testing
    • Changes, removals and additions to functionality must be covered by acceptance / integration tests or smoke tests - either already existing ones, or new ones, created by the author of the PR.

Pull Request Review

All pull requests must undergo a thorough review process before being merged.
The review process of the code PR should include code review, testing, and any necessary feedback or revisions.
Pull request reviews of functionality developed in other teams only review the given documentation and test reports.

Manual testing will not be performed by the reviewing team, and is the responsibility of the author of the PR.

For Node projects: It’s important to make sure changes in package.json are also affecting package-lock.json correctly.

If a dependency is not necessary, don’t add it.

When adding a new package as a dependency, make sure that the change is absolutely necessary. We would like to refrain from adding new dependencies when possible.
Documentation PRs in gitbook are reviewed by Snyk's content team. They will also advise on the best phrasing and structuring if needed.

Pull Request Approval

Once a pull request has been reviewed and all necessary revisions have been made, it is approved for merging into
the main codebase. The merging of the code PR is performed by the code owners, the merging of the documentation PR
by our content writers.

What does this PR do?

Where should the reviewer start?

How should this be manually tested?

Any background context you want to provide?

What are the relevant tickets?

Screenshots

Additional questions

@j-luong j-luong marked this pull request as ready for review September 5, 2024 13:13
@j-luong j-luong requested a review from a team as a code owner September 5, 2024 13:13
Copy link
Collaborator

@PeterSchafer PeterSchafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue: Please use the logic in gaf and remove the logic that was migrated.

@sandor-trombitas sandor-trombitas force-pushed the feat/CLI-509_configurableTmpDir branch 2 times, most recently from 8d4d735 to 009ed12 Compare September 10, 2024 05:48
cliv2/go.sum Outdated Show resolved Hide resolved
@sandor-trombitas sandor-trombitas force-pushed the feat/CLI-509_configurableTmpDir branch 2 times, most recently from 7768f38 to 0783488 Compare September 10, 2024 12:40
@PeterSchafer
Copy link
Collaborator

Please just make the commit message a bit more explanatory. This will fix the Danger Warning as well.

@PeterSchafer
Copy link
Collaborator

Issue: Please take a look at the failing test.

@sandor-trombitas sandor-trombitas force-pushed the feat/CLI-509_configurableTmpDir branch 3 times, most recently from 577c469 to 3ebf4d4 Compare September 12, 2024 07:19
@sandor-trombitas sandor-trombitas force-pushed the feat/CLI-509_configurableTmpDir branch 2 times, most recently from 01d8475 to b6da912 Compare September 12, 2024 14:06
@PeterSchafer PeterSchafer force-pushed the feat/CLI-509_configurableTmpDir branch from b6da912 to f0f2d6e Compare September 12, 2024 15:25
@PeterSchafer PeterSchafer merged commit 0c0d1a1 into main Sep 12, 2024
10 checks passed
@PeterSchafer PeterSchafer deleted the feat/CLI-509_configurableTmpDir branch September 12, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants