Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nuget plugin writes messages to stderr #5410

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

37IulianPopovici
Copy link
Contributor

@37IulianPopovici 37IulianPopovici commented Aug 12, 2024

Pull Request Submission

Please check the boxes once done.

The pull request must:

  • Reviewer Documentation
    • follow CONTRIBUTING rules
    • be accompanied by a detailed description of the changes
    • contain a risk assessment of the change (Low | Medium | High) with regards to breaking existing functionality. A change e.g. of an underlying language plugin can completely break the functionality for that language, but appearing as only a version change in the dependencies.
    • highlight breaking API if applicable
    • contain a link to the automatic tests that cover the updated functionality.
    • contain testing instructions in case that the reviewer wants to manual verify as well, to add to the manual testing done by the author.
    • link to the link to the PR for the User-facing documentation
  • User facing Documentation
    • update any relevant documentation in gitbook by submitting a gitbook PR, and including the PR link here
    • ensure that the message of the final single commit is descriptive and prefixed with either feat: or fix: , others might be used in rare occasions as well, if there is no need to document the changes in the release notes. The changes or fixes should be described in detail in the commit message for the changelog & release notes.
  • Testing
    • Changes, removals and additions to functionality must be covered by acceptance / integration tests or smoke tests - either already existing ones, or new ones, created by the author of the PR.

Pull Request Review

All pull requests must undergo a thorough review process before being merged.
The review process of the code PR should include code review, testing, and any necessary feedback or revisions.
Pull request reviews of functionality developed in other teams only review the given documentation and test reports.

Manual testing will not be performed by the reviewing team, and is the responsibility of the author of the PR.

For Node projects: It’s important to make sure changes in package.json are also affecting package-lock.json correctly.

If a dependency is not necessary, don’t add it.

When adding a new package as a dependency, make sure that the change is absolutely necessary. We would like to refrain from adding new dependencies when possible.
Documentation PRs in gitbook are reviewed by Snyk's content team. They will also advise on the best phrasing and structuring if needed.

Pull Request Approval

Once a pull request has been reviewed and all necessary revisions have been made, it is approved for merging into
the main codebase. The merging of the code PR is performed by the code owners, the merging of the documentation PR
by our content writers.

What does this PR do?

Updated snyk-nuget-plugin in order to fix a bug where the usage of --json and --dotnet-runtime-resolution will produce invalid JSON output due to the user messages displayed by the plugin. The plugin was updated to write it's user facing messages to stderr instead of stdout.

No risk, this is a bug fix.

snyk/snyk-nuget-plugin#217
snyk/snyk-nuget-plugin#218

Where should the reviewer start?

How should this be manually tested?

Use this fixture and do a scan with --dotnet-runtime-resolution and --json.

Any background context you want to provide?

#5358

What are the relevant tickets?

Screenshots

Additional questions

@37IulianPopovici 37IulianPopovici self-assigned this Aug 12, 2024
@37IulianPopovici 37IulianPopovici requested a review from a team as a code owner August 12, 2024 08:08
@37IulianPopovici 37IulianPopovici force-pushed the fix/nuget-plugin-writes-messages-to-stderr branch 2 times, most recently from dc8a46d to 3ea5e43 Compare August 13, 2024 10:29
Copy link
Contributor

@cmars cmars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@37IulianPopovici 37IulianPopovici force-pushed the fix/nuget-plugin-writes-messages-to-stderr branch 2 times, most recently from a9c87ab to 445f685 Compare August 14, 2024 13:00
@37IulianPopovici 37IulianPopovici force-pushed the fix/nuget-plugin-writes-messages-to-stderr branch from 445f685 to 459d1e6 Compare August 16, 2024 07:06
@37IulianPopovici 37IulianPopovici force-pushed the fix/nuget-plugin-writes-messages-to-stderr branch from 459d1e6 to 12ae759 Compare August 16, 2024 10:24
@37IulianPopovici 37IulianPopovici merged commit 959b5b1 into main Aug 16, 2024
11 checks passed
@37IulianPopovici 37IulianPopovici deleted the fix/nuget-plugin-writes-messages-to-stderr branch August 16, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants