-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: print all dep-graphs of a container scan #5399
Conversation
When printing the dep-graph results from Snyk container SCA, the code would escape early and omit all the dep-graphs that might have been found during remote analysis. This commit moves the dep-graph printing during container SCA to after the remote analysis call, this way including additional dep-graphs of applications within the container image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass looks good! See suggestion below to help this scale better for large objects. Heap space is unfortunately capped in the NodeJS process though, which can lead to incorrect outputs (or possibly process crashes due to OOMs). We have a couple open tickets where containers have tripped this limit.
|
if you are following along, you might be able to tell that i'm brute-forcing this implementation because i cannot get the test suite to run on my machine! :fistshake:
Too much happening, too much failing, |
@cmars will close this in favour of two other PRs. |
What does this PR do?
When printing the dep-graph results from Snyk container SCA, the code would escape early and omit all the dep-graphs that might have been found during remote analysis. This commit moves the dep-graph printing during container SCA to after the remote analysis call, this way including additional dep-graphs of applications within the container image.