Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add several ts cli launch configs #5353

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

cmars
Copy link
Contributor

@cmars cmars commented Jun 27, 2024

Launching the Typescript CLI in the debugger can be useful for tracing through and introspecting on CLI behavior.

Adding a few common test workflows that transit the Typescript CLI codebase along different routes.

Pull Request Submission

Please check the boxes once done.

The pull request must:

  • Reviewer Documentation
    • follow CONTRIBUTING rules
    • be accompanied by a detailed description of the changes
    • contain a risk assessment of the change (Low | Medium | High) with regards to breaking existing functionality. A change e.g. of an underlying language plugin can completely break the functionality for that language, but appearing as only a version change in the dependencies.
    • highlight breaking API if applicable
    • contain a link to the automatic tests that cover the updated functionality.
    • contain testing instructions in case that the reviewer wants to manual verify as well, to add to the manual testing done by the author.
    • link to the link to the PR for the User-facing documentation
  • User facing Documentation
    • update any relevant documentation in gitbook by submitting a gitbook PR, and including the PR link here
    • ensure that the message of the final single commit is descriptive and prefixed with either feat: or fix: , others might be used in rare occasions as well, if there is no need to document the changes in the release notes. The changes or fixes should be described in detail in the commit message for the changelog & release notes.
  • Testing
    • Changes, removals and additions to functionality must be covered by acceptance / integration tests or smoke tests - either already existing ones, or new ones, created by the author of the PR.

Pull Request Review

All pull requests must undergo a thorough review process before being merged.
The review process of the code PR should include code review, testing, and any necessary feedback or revisions.
Pull request reviews of functionality developed in other teams only review the given documentation and test reports.

Manual testing will not be performed by the reviewing team, and is the responsibility of the author of the PR.

For Node projects: It’s important to make sure changes in package.json are also affecting package-lock.json correctly.

If a dependency is not necessary, don’t add it.

When adding a new package as a dependency, make sure that the change is absolutely necessary. We would like to refrain from adding new dependencies when possible.
Documentation PRs in gitbook are reviewed by Snyk's content team. They will also advise on the best phrasing and structuring if needed.

Pull Request Approval

Once a pull request has been reviewed and all necessary revisions have been made, it is approved for merging into
the main codebase. The merging of the code PR is performed by the code owners, the merging of the documentation PR
by our content writers.

What does this PR do?

See top posting.

Where should the reviewer start?

How should this be manually tested?

With this branch checked out, in VS Code you should have several new launch configurations available (see screenshot below).

Set breakpoints in the Typescript CLI and you can inspect what's happening at various points in the execution flow.

Any background context you want to provide?

I'm constantly setting these kinds of launch configs up, then losing them and recreating them. Maybe the rest of the team will find them helpful?

What are the relevant tickets?

Screenshots

Screenshot 2024-06-27 at 3 02 20 PM

Additional questions

@cmars cmars requested a review from a team as a code owner June 27, 2024 20:02
@cmars cmars force-pushed the chore/ts-cli-launch-configs-debug branch from 5349570 to a688381 Compare June 27, 2024 20:52
@thisislawatts thisislawatts force-pushed the chore/ts-cli-launch-configs-debug branch from a688381 to 200dc24 Compare September 3, 2024 14:52
@cmars cmars force-pushed the chore/ts-cli-launch-configs-debug branch from 200dc24 to a74aaf3 Compare September 3, 2024 23:16
Launching the Typescript CLI in the debugger can be useful for
tracing through and introspecting on CLI behavior.

Adding a few common test workflows that transit the Typescript CLI
codebase along different routes.
@thisislawatts thisislawatts force-pushed the chore/ts-cli-launch-configs-debug branch from a74aaf3 to e4e1832 Compare September 4, 2024 09:17
@thisislawatts thisislawatts merged commit 8638d9d into main Sep 4, 2024
11 checks passed
@thisislawatts thisislawatts deleted the chore/ts-cli-launch-configs-debug branch September 4, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants