-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: point snyk policy out urls to snyk.io #5338
fix: point snyk policy out urls to snyk.io #5338
Conversation
1f646c2
to
c4d9d8a
Compare
748e3f6
to
9ff30da
Compare
9ff30da
to
06c79da
Compare
1c5c142
to
6b3dc5f
Compare
@@ -60,3 +60,11 @@ function displayRule(title) { | |||
); | |||
}; | |||
} | |||
|
|||
function apiRoot(vulnId: string) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: Will these URLs not/never depend on the user configured instance like eu, au, ...?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so as I've implemented it based on the logic in registry but let me confirm with the security team, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is correct, as it is semi-static data displayed on the un-authenticated snyk site, not part of the per-instance authorized application.
a809421
to
4fd0901
Compare
`snyk policy` output includes the correct url information, udading the url to the snyk.io root rather than security.snyk.io. https://snyksec.atlassian.net/browse/IGNR-245
4fd0901
to
6685a34
Compare
snyk policy
output includes the correct url information, udading the url to the snyk.io root rather than security.snyk.io. https://snyksec.atlassian.net/browse/CLI-482Pull Request Submission
Please check the boxes once done.
The pull request must:
feat:
orfix:
, others might be used in rare occasions as well, if there is no need to document the changes in the release notes. The changes or fixes should be described in detail in the commit message for the changelog & release notes.Pull Request Review
All pull requests must undergo a thorough review process before being merged.
The review process of the code PR should include code review, testing, and any necessary feedback or revisions.
Pull request reviews of functionality developed in other teams only review the given documentation and test reports.
Manual testing will not be performed by the reviewing team, and is the responsibility of the author of the PR.
For Node projects: It’s important to make sure changes in
package.json
are also affectingpackage-lock.json
correctly.If a dependency is not necessary, don’t add it.
When adding a new package as a dependency, make sure that the change is absolutely necessary. We would like to refrain from adding new dependencies when possible.
Documentation PRs in gitbook are reviewed by Snyk's content team. They will also advise on the best phrasing and structuring if needed.
Pull Request Approval
Once a pull request has been reviewed and all necessary revisions have been made, it is approved for merging into
the main codebase. The merging of the code PR is performed by the code owners, the merging of the documentation PR
by our content writers.
What does this PR do?
Where should the reviewer start?
How should this be manually tested?
Any background context you want to provide?
What are the relevant tickets?
Screenshots
Additional questions