feat(instrumentation): integrate analytics report workflow CLI-302 #5259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgyorke
force-pushed
the
feat/integrate-analytics-report-workflow-cli-302
branch
4 times, most recently
from
590437f to
c530396
Compare
mgyorke
force-pushed
the
feat/integrate-analytics-report-workflow-cli-302
branch
from
c530396 to
731b03d
Compare
mgyorke
force-pushed
the
feat/integrate-analytics-report-workflow-cli-302
branch
2 times, most recently
from
fc6369a to
642a7c3
Compare
mgyorke
force-pushed
the
feat/integrate-analytics-report-workflow-cli-302
branch
5 times, most recently
from
3494fa5 to
6a8c787
Compare
cliv2/cmd/cliv2/main.go
Outdated
| v2InstrumentationData, | ||
| ) | ||
|
|
||
| logger.Trace().Msg("Invoking report analytics workflow") |
There was a problem hiding this comment.
Suggestion: let's remove the workflow name in logs and comments, the name is not perfect, so let's not spread it more than necessary.
There was a problem hiding this comment.
You're right! I changed the logs on that line and around it, I think it's more inline with what we want.
cliv2/cmd/cliv2/main.go
Outdated
| ) | ||
|
|
||
| if err != nil { | ||
| logger.Err(err).Msg("Failed to invoke analytics") |
There was a problem hiding this comment.
Suggestion: Same as above! Also success and failure logs should use the same wording.
| }); | ||
|
|
||
| expect(requests.length).toBeGreaterThan(0); | ||
| requests.forEach((req) => { |
There was a problem hiding this comment.
Question: Are these really multiple requests? Looks like before there was only one.
| command: 'test', | ||
| metadata: { | ||
| 'upgradable-snyk-protect-paths': 0, | ||
| // server.popRequest(); |
There was a problem hiding this comment.
Suggestion: remove commented code
mgyorke
force-pushed
the
feat/integrate-analytics-report-workflow-cli-302
branch
3 times, most recently
from
1f164b1 to
be8e46d
Compare
mgyorke
force-pushed
the
feat/integrate-analytics-report-workflow-cli-302
branch
from
be8e46d to
1f97192
Compare
thisislawatts
approved these changes
May 31, 2024
thisislawatts
deleted the
feat/integrate-analytics-report-workflow-cli-302
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Submission
Please check the boxes once done.
The pull request must:
feat:orfix:, others might be used in rare occasions as well, if there is no need to document the changes in the release notes. The changes or fixes should be described in detail in the commit message for the changelog & release notes.Pull Request Review
All pull requests must undergo a thorough review process before being merged.
The review process of the code PR should include code review, testing, and any necessary feedback or revisions.
Pull request reviews of functionality developed in other teams only review the given documentation and test reports.
Manual testing will not be performed by the reviewing team, and is the responsibility of the author of the PR.
For Node projects: It’s important to make sure changes in
package.jsonare also affectingpackage-lock.jsoncorrectly.If a dependency is not necessary, don’t add it.
When adding a new package as a dependency, make sure that the change is absolutely necessary. We would like to refrain from adding new dependencies when possible.
Documentation PRs in gitbook are reviewed by Snyk's content team. They will also advise on the best phrasing and structuring if needed.
Pull Request Approval
Once a pull request has been reviewed and all necessary revisions have been made, it is approved for merging into
the main codebase. The merging of the code PR is performed by the code owners, the merging of the documentation PR
by our content writers.
What does this PR do?
Where should the reviewer start?
How should this be manually tested?
Any background context you want to provide?
This PR depends on this and this pull requests.
What are the relevant tickets?
Screenshots
Additional questions