-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: merge release into main #5222
Conversation
…idate chore: Update release candidate
fix(ci): add deployment steps to release branches
hotfix: dverbose cyclic dependencies support
|
7599db6
to
d3be47f
Compare
* chore: upgrade to newer windows runner * fix: use linux based hello-world image in windows runners UNIFY-128 --------- Co-authored-by: adrobuta <[email protected]>
* feat: parse data from output workflow * fix: avoid overwriting err * test: inline helper function as it is no longer reusable * fix: fix shadow declaration * chore: use new GAF version * chore: remove sausage finger typo * feat(whoami): switch from experimental endpoint to ga version --------- Co-authored-by: Peter Schäfer <[email protected]>
#5181) * feat: [OSM-1040] Added pnpm support under 'enablePnpmCli' feature flag
…re/test_update_main
Pull Request Submission
Please check the boxes once done.
The pull request must:
feat:
orfix:
, others might be used in rare occasions as well, if there is no need to document the changes in the release notes. The changes or fixes should be described in detail in the commit message for the changelog & release notes.Pull Request Review
All pull requests must undergo a thorough review process before being merged.
The review process of the code PR should include code review, testing, and any necessary feedback or revisions.
Pull request reviews of functionality developed in other teams only review the given documentation and test reports.
Manual testing will not be performed by the reviewing team, and is the responsibility of the author of the PR.
For Node projects: It’s important to make sure changes in
package.json
are also affectingpackage-lock.json
correctly.If a dependency is not necessary, don’t add it.
When adding a new package as a dependency, make sure that the change is absolutely necessary. We would like to refrain from adding new dependencies when possible.
Documentation PRs in gitbook are reviewed by Snyk's content team. They will also advise on the best phrasing and structuring if needed.
Pull Request Approval
Once a pull request has been reviewed and all necessary revisions have been made, it is approved for merging into
the main codebase. The merging of the code PR is performed by the code owners, the merging of the documentation PR
by our content writers.
What does this PR do?
Where should the reviewer start?
How should this be manually tested?
Any background context you want to provide?
What are the relevant tickets?
Screenshots
Additional questions