Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Deploy regular CLI builds to a new preview channel #5042

Merged
merged 4 commits into from
Feb 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -728,7 +728,8 @@ workflows:
- '/.*e2e.*/'

- release-s3:
name: upload latest
name: upload preview
deployment: preview
context: team-hammerhead-common-deploy-tokens
requires:
- Validate NPM artifacts (docker-amd64)
Expand All @@ -754,6 +755,16 @@ workflows:
branches:
only: master

- release-s3:
name: upload latest
deployment: latest
context: team-hammerhead-common-deploy-tokens
requires:
- upload preview
filters:
branches:
only: master

- release-github:
name: upload github
context: team-hammerhead-common-deploy-tokens
Expand Down Expand Up @@ -1149,14 +1160,18 @@ jobs:
SNYK_TOKEN=${TEST_SNYK_TOKEN} ./snyk woof
release-s3:
parameters:
deployment:
type: string
default: latest
executor: docker-amd64
steps:
- prepare-workspace
- aws-cli/install:
version: << pipeline.parameters.aws_version >>
- run:
name: Publish to S3
command: ./release-scripts/upload-artifacts.sh latest
name: Publish to S3 ( << parameters.deployment >> )
command: ./release-scripts/upload-artifacts.sh << parameters.deployment >>
- failed-release-notification

release-github:
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ release-pre:
@echo "-- Validating artifacts"
@./release-scripts/validate-checksums.sh
@echo "-- Validating upload permissions"
@./release-scripts/upload-artifacts.sh --dry-run latest github npm
@./release-scripts/upload-artifacts.sh --dry-run preview latest github npm
@echo "-- Publishing to S3 /version"
@./release-scripts/upload-artifacts.sh version

Expand Down
Loading