-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#2439): populate CVSS scores in SARIF files #5014
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a request for code comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs further discussion with @snyk/cli
Hello, what is the status of this PR? We are using both Snyk and Trivy for scans in GIthub Actions and pushing them to Security Dashboard. The problem with Snyk is that is doesn't report security-severity. This means that all reports by Snyk get a warning or note severity instead of medium or low, which hides them in later pages of github advanced security. Example: Snyk and Trivy report the same vulnerability but Trivy reports it as Low severity and Snyk as Medium severity. In Github Security Dashboard, Trivy will get correct severity of Low, but Snyk gets a wrong severity of "warning" instead of "medium", and it is placed below the severity of Trivy, thus making us think the severity is Low or below. |
Hi @ipanagiotidis, apologies for the delay, I've been AFK for a few weeks due to a knee surgery and just returned today. I intend to address the comments in this PR, then move the code to a new branch to prepare for merge. Hang tight! 🙏 |
61f6aec
to
1dff3a8
Compare
Pull request was closed
1dff3a8
to
8a2f0c7
Compare
01bbcaf
to
39cd4a3
Compare
39cd4a3
to
13da263
Compare
Unfortunately this broke import of Sarif files to GitHub as it expects quoted string for security-severity as in doc https://docs.github.com/en/code-security/code-scanning/integrating-with-code-scanning/sarif-support-for-code-scanning#reportingdescriptor-object |
Darn! Sorry about that @pgrabowski - I overlooked "A string representing a score" 🤦♂️ Thanks so much @thisislawatts for the quick fix 🙏 |
Addresses #2439.
Adds
security-severity
to open source and container SARIF output.