-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add targetRuntime
meta information to monitor
#4916
Conversation
e6ba7fc
to
4836057
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking. We need to verify that this will not break existing pipelines (i.e. that tests map to the same projects that they used to, and that this won't create a flood of new projects in the system)
@darscan I already did that. |
So, you've manually tested every combination of cli-plugin and input argument, for every ecosystem against existing projects in the system? |
@darscan I checked which CLI plugin would populate |
@darscan it only applies to runs done with the beta-flag |
Thanks, that clears things up a lot 👍 |
Disabling auto-merge and double-checking everything. @darscan made me paranoid. |
But what happens when that feature goes GA? |
Continuing the discussion outside this PR. |
The entire foundation for utilizing the
targetRuntime
exists in the Snyk backend, but is not utilized bysnyk monitor
.Adding the
targetRuntime
will decorate thesnyk monitor
results with the Target Runtime information, used in multiple language ecosystems.Here an example from .NET, before:
After:
This will also pave the way for support of
snyk monitor
of a single project with multiple target runtimes attached, without overwriting the same project multiple times.