feat: remove deprecated managed IaC drift detection #4908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chdorner-snyk
force-pushed
the
IAC-2657/remove-managed-drift-detection
branch
3 times, most recently
from
0b0f051 to
06584cf
Compare
chdorner-snyk
requested review from
robh-snyk and
andreeaneata
and removed request for
robh-snyk
andreeaneata
approved these changes
Dec 12, 2023
|
Hey @chdorner-snyk , would you please use the PR template? Especially, customer communication both in documentation and updates.snyk.io would need some mentions here :). |
|
@bastiandoetsch yeah, this PR has been open in draft mode for a very long time. Updated the PR description now. |
bastiandoetsch
approved these changes
Dec 13, 2023
|
Can't really check the logic features, but that's what @andreeaneata 's review is for ;) |
managed drift detection has been deprecated with e6ad44a and is now being removed after a 90-day period.
chdorner-snyk
force-pushed
the
IAC-2657/remove-managed-drift-detection
branch
from
06584cf to
aef0823
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
managed drift detection has been deprecated with e6ad44a and is now being removed after a (more thn) 90-day period, this PR removes support for it. This mainly means:
--deeparg to driftctl anymoreWhere should the reviewer start?
see next
How should this be manually tested?
Best way is to run a few commands to ensure that the functionality that should still work still works:
snyk iac describe --only-unmanagedsnyk iac describe --only-unmanaged --jsonsnyk iac describe --only-unmanaged --htmlsnyk iac describe --only-unmanaged --html-file-output=output.htmlSince we now only have one mode, so the command now also works without any flags:
snyk iac describeFunctionality that changed:
snyk iac describe --only-managed- now errorssnyk iac describe --deep- still works, but only uses the unmanaged modeCLI help and the documentation has already changed, i.e. CLI help has changed here.
Any background context you want to provide?
We've deprecated managed drift detection in v1.1190.0, and communicated a 90-day deprecation window. The end of the deprecation period was reached on September 30th, we're now finally fully removing this functionality.
What are the relevant tickets?
IAC-2657
Screenshots
–
Additional questions
–