feat: support -- arguments for sbom and other extensions [HEAD-861] #4892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterSchafer
force-pushed
the
feat/HEAD-861_support_unknown_args
branch
from
ae3b5ac to
3680867
Compare
PeterSchafer
changed the title
mcombuechen
approved these changes
Oct 4, 2023
PeterSchafer
force-pushed
the
feat/HEAD-861_support_unknown_args
branch
from
96f58f2 to
a6b9039
Compare
| _, err := engine.Invoke(basic_workflows.WORKFLOWID_LEGACY_CLI) | ||
| return err | ||
| } | ||
|
|
||
| func getGlobalFLags() *pflag.FlagSet { | ||
| globalConfiguration := workflow.GetGlobalConfiguration() | ||
| globalFLags := workflow.FlagsetFromConfigurationOptions(globalConfiguration) | ||
| globalConfigurationOptions := workflow.GetGlobalConfiguration() |
There was a problem hiding this comment.
suggestion (non-blocking): let's rename GetGlobalConfiguration to GetGlobalConfigurationOptions in a follow-up PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Where should the reviewer start?
How should this be manually tested?
Both invocations should give an error that they can't go list "arbitrary content"
snyk sbom cliv2 --format cyclonedx1.4+json -- arbitrary contentsnyk test cliv2 -- arbitrary contentAny background context you want to provide?
-What are the relevant tickets?
HEAD-861
Screenshots
Additional questions