fix: new json field infrastructureAsCodeSuccesses GA

snyk · Aug 22, 2024 · d4b1ded · d4b1ded
1 parent bfd3036
commit d4b1ded
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 400 deletions.
diff --git a/src/lib/iac/test/v2/json-old.ts b/src/lib/iac/test/v2/json-old.ts
diff --git a/src/lib/iac/test/v2/output.ts b/src/lib/iac/test/v2/output.ts
@@ -1,9 +1,7 @@
 import { Ora } from 'ora';
 import { EOL } from 'os';
 import { convertEngineToJsonResults } from './json';
-import { convertEngineToJsonResults as oldConvertEngineToJsonResults } from './json-old';
 import { TestOutput } from './scan/results';
-import { previewFeaturesEnabled } from '../../../preview-features-enabled';
 import { TestCommandResult } from '../../../../cli/commands/types';
 import {
   formatIacTestFailures,
@@ -84,15 +82,10 @@ function buildTestCommandResultData({
     scanResult.results?.metadata?.projectName ?? path.basename(process.cwd());
 
   const jsonData = jsonStringifyLargeObject(
-    previewFeaturesEnabled()
-      ? convertEngineToJsonResults({
-          results: scanResult,
-          projectName,
-        })
-      : oldConvertEngineToJsonResults({
-          results: scanResult,
-          projectName,
-        }),
+    convertEngineToJsonResults({
+      results: scanResult,
+      projectName,
+    }),
   );
 
   const sarifData = jsonStringifyLargeObject(

diff --git a/src/lib/iac/test/v2/scan/index.ts b/src/lib/iac/test/v2/scan/index.ts
@@ -13,7 +13,6 @@ import config from '../../../../config';
 import { api, getOAuthToken } from '../../../../api-token';
 import envPaths from 'env-paths';
 import { restoreEnvProxy } from '../../../env-utils';
-import { previewFeaturesEnabled } from '../../../../preview-features-enabled';
 
 const debug = newDebug('snyk-iac');
 const debugOutput = newDebug('snyk-iac:output');
@@ -125,13 +124,10 @@ function processFlags(
 
   flags.push('-output', outputPath);
 
-  // TODO: IAC-2962 - Remove condition after the feature is GA
-  if (previewFeaturesEnabled()) {
-    // to reduce the size of the output
-    flags.push('-exclude-raw-results');
-    // required for infrastructureAsCodeSuccesses to be populated
-    flags.push('-include-passed-vulnerabilities');
-  }
+  // to reduce the size of the output
+  flags.push('-exclude-raw-results');
+  // required for infrastructureAsCodeSuccesses to be populated
+  flags.push('-include-passed-vulnerabilities');
 
   if (options.severityThreshold) {
     flags.push('-severity-threshold', options.severityThreshold);