Merge pull request #763 from snyk/fix/binary-building

fix: version retrieval in preflight check
snyk · May 10, 2024 · f9399dd · f9399dd
2 parents 28f12c6 + 4fba441
commit f9399dd
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 7 deletions.
diff --git a/lib/client/checks/config/brokerClientVersionCheck.ts b/lib/client/checks/config/brokerClientVersionCheck.ts
@@ -7,7 +7,7 @@ export const validateBrokerClientVersionAgainstServer = async (
   checkOptions: CheckOptions,
   config,
 ) => {
-  const clientVersion = version();
+  const clientVersion = `${version}`;
   if (clientVersion != 'local') {
     const req: PostFilterPreparedRequest = {
       url: `${config.BROKER_SERVER_URL}/healthcheck`,

diff --git a/test/unit/client/checks/config/brokerClientVersionCheck.test.ts b/test/unit/client/checks/config/brokerClientVersionCheck.test.ts
@@ -14,9 +14,7 @@ jest.mock('../../../../../lib/common/utils/version', () => {
   return {
     __esModule: true,
     ...originalModule,
-    default: () => {
-      return '4.180.0';
-    },
+    default: '4.180.0',
   };
 });
 

diff --git a/test/unit/client/checks/config/brokerClientVersionSkipDevLocalVersionCheck.test.ts b/test/unit/client/checks/config/brokerClientVersionSkipDevLocalVersionCheck.test.ts
@@ -12,9 +12,7 @@ jest.mock('../../../../../lib/common/utils/version', () => {
   return {
     __esModule: true,
     ...originalModule,
-    default: () => {
-      return 'local';
-    },
+    default: 'local',
   };
 });