Skip to content

Commit

Permalink
fix: github graphql endpoint for github-com docker image
Browse files Browse the repository at this point in the history
The default .env template for github set the GraphQL endpoint to $GTIHUB/api, which is correct for GHE, but incorrect for github.com.

Overriding the default .env template values in the Dockerfile for both github.com and GHE to fix github.com endpoint, and be explicit about this setting
  • Loading branch information
Anton Drukh committed Feb 15, 2018
1 parent 4b4f913 commit bc68528
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
5 changes: 4 additions & 1 deletion dockerfiles/github-com/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,12 @@ ENV PORT 7341
# GitHub host is github.com
ENV GITHUB github.com

# The URL that the github API should be accessed, excluding scheme.
# Github API endpoint, excluding scheme.
ENV GITHUB_API api.github.com

# Github GraphQL API endpoint, excluding scheme.
ENV GITHUB_GRAPHQL api.github.com

# The URL of the Snyk broker server
ENV BROKER_SERVER_URL https://broker.snyk.io

Expand Down
5 changes: 4 additions & 1 deletion dockerfiles/github-enterprise/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,12 @@ RUN broker init github
# The host where your GitHub Enterprise is running, excluding scheme.
ENV GITHUB=your.ghe.domain.com

# The URL that the github API should be accessed at.
# Github API endpoint, excluding scheme.
ENV GITHUB_API $GITHUB/api/v3

# Github GraphQL API endpoint, excluding scheme.
ENV GITHUB_GRAPHQL $GITHUB/api

# The port used by the broker client to accept webhooks
# Default value is 7341
ENV PORT 7341
Expand Down

0 comments on commit bc68528

Please sign in to comment.