Skip to content

Commit

Permalink
Merge branch 'master' into feat/allow_native_pr_experience
Browse files Browse the repository at this point in the history
  • Loading branch information
ildikodencsak committed Aug 21, 2024
2 parents 4ff262f + b8d603d commit 3aa8892
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 7 deletions.
2 changes: 1 addition & 1 deletion lib/client/routesHandler/systemCheckHandler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export const systemCheckHandler = async (req: Request, res: Response) => {
}
validationResults.push(result);
}
res.status(isValidationPassing ? 200 : 500).send(validationResults);
res.status(isValidationPassing ? 200 : 500).json(validationResults);
} else {
const brokerClientValidationMethod =
clientOpts.config.brokerClientValidationMethod || 'GET';
Expand Down
9 changes: 5 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
"typescript": "^4.9.3"
},
"dependencies": {
"axios": "1.6.8",
"axios": "1.7.4",
"axios-retry": "^3.9.1",
"body-parser": "^1.19.0",
"bunyan": "^1.8.12",
Expand Down
4 changes: 3 additions & 1 deletion test/functional/systemcheck-universal.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,9 @@ describe('broker client systemcheck endpoint', () => {

const response = await axiosClient.get(
`http://localhost:${bc.port}/systemcheck`,
{ timeout: 10_000 },
{
timeout: 10_000,
},
);

expect(response.data).toBeInstanceOf(Array);
Expand Down

0 comments on commit 3aa8892

Please sign in to comment.