chore: resolve ecosystem based on package type #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package ecosystems were previously determined based on file extension. This would not scale as we expand the plugin with further ecosystems, e.g. both `pypi` and `cocoapods` use the `.tar.gz` extension. This commit switches to `packageType` field provided by Artifactory's `RepositoryConfiguration` model in order to determine the ecosystem without relying on file extensions.
alina-ilie
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package ecosystems were previously determined based on file extension. This would not scale as we expand the plugin with further ecosystems, e.g. both
pypiandcocoapodsuse the.tar.gzextension.This commit switches to
packageTypefield provided by Artifactory'sRepositoryConfigurationmodel in order to determine the ecosystem without relying on file extensions.