Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add instances for Reverse #242

Merged
merged 2 commits into from
Sep 13, 2024
Merged

add instances for Reverse #242

merged 2 commits into from
Sep 13, 2024

Conversation

marcosh
Copy link
Contributor

@marcosh marcosh commented Sep 10, 2024

add MonoFunctor, MonoFoldable and MonoTraversable instances for Reverse f a

snoyberg
snoyberg requested changes Sep 12, 2024
View reviewed changes
Copy link
Owner

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you make a minor version bump, add @since comments to the new instances, and update the changelog?

@marcosh
Copy link
Contributor Author

marcosh commented Sep 12, 2024

LGTM. Can you make a minor version bump, add @since comments to the new instances, and update the changelog?

done! Thanks for the pointers

snoyberg
snoyberg approved these changes Sep 13, 2024
View reviewed changes
Copy link
Owner

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@snoyberg snoyberg merged commit 5cff788 into snoyberg:master Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snoyberg snoyberg snoyberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcosh @snoyberg