Fix NPEs in TypesAccumulator #1363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have another accumulator... the TimestampsAccumulator. But I think that does not need the same fix, because it's internal state is a |
spenes
approved these changes
Oct 4, 2024
We've seen exceptions in spark executors like: ``` java.lang.NullPointerException: Cannot invoke "scala.collection.mutable.Set.isEmpty()" because the return value of "com.snowplowanalytics.snowplow.rdbloader.transformer.batch.spark.TypesAccumulator.accum()" is null ``` The error is coming from our Spark Accumulator for accumulating Iglu types. This is similar to [an issue previously seen][1] in Spark's own `CollectionAccumulator`. That issue [was fixed in Spark][2] by making the accumulator's internal state non-final, and synchronizing access to the internal state. So here we make the exact same change to our own Accumulator. It is a rare race condition which is hard to reproduce. [1]: https://issues.apache.org/jira/browse/SPARK-20977 [2]: apache/spark#31540
spenes
force-pushed
the
types-accumulator-npe
branch
from
31e278b
to
d540e99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've seen exceptions in spark executors like:
The error is coming from our Spark Accumulator for accumulating Iglu types. This is similar to an issue previously seen in Spark's own
CollectionAccumulator. That issue was fixed in Spark by making the accumulator's internal state non-final, and synchronizing access to the internal state. So here we make the exact same change to our own Accumulator.It is a rare race condition which is hard to reproduce.