Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work on base_create_snowplow_events_this_run model #186

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

ilias1111
Copy link
Contributor

@ilias1111 ilias1111 commented Oct 28, 2024

Description

Bug fix for spark, reading the whole event table when is not needed

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Checklist

  • πŸ’£ Is your change a breaking change?
  • πŸ“– I have updated the CHANGELOG.md

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ““ internal package docs (ymls, macros, readme, if applicable)
  • πŸ“• I have raised a Snowplow documentation PR if applicable (Link here if required)
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@ilias1111 ilias1111 changed the base branch from main to Release/snowplow-utils/0.17.1 October 28, 2024 08:27
@ilias1111 ilias1111 marked this pull request as ready for review October 28, 2024 10:02
@ilias1111 ilias1111 requested a review from a team as a code owner October 28, 2024 10:02
@ilias1111 ilias1111 changed the title Update base_create_snowplow_events_this_run.sql Work on base_create_snowplow_events_this_run model Oct 28, 2024
Copy link
Contributor

@agnessnowplow agnessnowplow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ilias1111 ilias1111 merged commit 3f9d9b3 into Release/snowplow-utils/0.17.1 Oct 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants