Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1819531: lqb bug fixes #2670

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

sfc-gh-aalam
Copy link
Contributor

@sfc-gh-aalam sfc-gh-aalam commented Nov 22, 2024

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1819531

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
  3. Please describe how your code solves the related issue.

    i) SNOW-1748140: Modify schema_expression to be structured type aware. #2659 Fix bug where referenced_ctes is not propagated to root when root source plan is one of SnowflakeCreateTable, CreateViewCommand, TableUpdate, TableDelete, TableMerge, ConpyIntoLocationNode.
    ii) fix a bug where relaxed_pipeline_breaker and is_valid_for_replacement properties for SnowflakePlan and SelectSnowflakePlan were not read correctly
    iii) updated plan plotter to color nodes that are not valid for replacement with red color.
    iv) updated plan plotter to only plot if root score is above a threshold to avoid complex plan being overwritten by simpler ones during.

@sfc-gh-aalam sfc-gh-aalam added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Nov 22, 2024
@sfc-gh-aalam sfc-gh-aalam marked this pull request as ready for review November 25, 2024 21:03
@sfc-gh-aalam sfc-gh-aalam requested review from a team as code owners November 25, 2024 21:03
Copy link

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

Copy link

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant