-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1819531: lqb bug fixes #2670
Open
sfc-gh-aalam
wants to merge
12
commits into
main
Choose a base branch
from
aalam-SNOW-1819531-lqb-bug-fixes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+84
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-aalam
added
the
NO-CHANGELOG-UPDATES
This pull request does not need to update CHANGELOG.md
label
Nov 22, 2024
sfc-gh-aalam
requested review from
sfc-gh-smirzaei,
sfc-gh-jdu and
sfc-gh-yixie
November 25, 2024 21:03
Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing |
Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1819531
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
i) SNOW-1748140: Modify schema_expression to be structured type aware. #2659 Fix bug where
referenced_ctes
is not propagated to root when root source plan is one ofSnowflakeCreateTable
,CreateViewCommand
,TableUpdate
,TableDelete
,TableMerge
,ConpyIntoLocationNode
.ii) fix a bug where
relaxed_pipeline_breaker
andis_valid_for_replacement
properties forSnowflakePlan
andSelectSnowflakePlan
were not read correctlyiii) updated plan plotter to color nodes that are not valid for replacement with red color.
iv) updated plan plotter to only plot if root score is above a threshold to avoid complex plan being overwritten by simpler ones during.