SNOW-1651983: Upgrade azure storage sdk v8 to v12, fix authenticated proxy issue #1895
+517
−248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrates the azure storage interactions to the V12 api. Still WIP, requires additional error handling, a bit of refactoring and new unit tests
…ve map for user metadata
| @@ -25,7 +25,9 @@ | |||
| <avro.version>1.8.1</avro.version> | |||
| <awaitility.version>4.2.0</awaitility.version> | |||
| <awssdk.version>1.12.655</awssdk.version> | |||
| <azure.storage.version>5.0.0</azure.storage.version> | |||
| <azure.storage.blob.version>12.26.1</azure.storage.blob.version> | |||
| <azure.storage.version>8.0.0</azure.storage.version> | |||
There was a problem hiding this comment.
the newest is 8.6.6 - can we use it?
There was a problem hiding this comment.
Right, I haven't noticed the newer version but it'll be rather no-op anyway
sfc-gh-dprzybysz
changed the title
sfc-gh-dprzybysz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The
azure-storagesdk aka v8 is on the retirement path (retirement notice). At the same time it seems that it's causing problems with accessing stages via authenticated proxy.This PR addresses both issues by migrating the
azure-storagesdk (v8) toazure-storage-blobsdk (v12)SNOW-1651983
TODO
Testing
Pre-review self checklist
masterbranchmvn -P check-style validate)mvn verifyand inspecttarget/japicmp/japicmp.html)SNOW-XXXX: