WIP Implement SfTest and sinceVersion #1583
Conversation
|
|
||
| @Retention(RetentionPolicy.RUNTIME) | ||
| @Target({ElementType.METHOD, ElementType.TYPE}) | ||
| public @interface SfTest { |
There was a problem hiding this comment.
annotation could be put on class, not only method - is this class aware of it?
are we able to handle different version on both levels? e.g. class declares availability since 3.14.5 whereas method declares availability for version 3.14.6
another question is that during implemntation we are not sure which version will be released so the given version should be last version that does not have the tested feature
| @Override | ||
| public Statement apply(Statement statement, FrameworkMethod frameworkMethod, Object o) { | ||
| SfTest sfTest = frameworkMethod.getAnnotation(SfTest.class); | ||
| if (sfTest == null || sfTest.sinceVersion() == null) { |
There was a problem hiding this comment.
version parameter should be mandatory - if not why don't use normal test paramter?
| this.patch = patch; | ||
| } | ||
|
|
||
| private static Version parse(String str) { |
There was a problem hiding this comment.
it could be secondary constructor
| return statement; | ||
| } | ||
| Version testSinceVersion = Version.parse(sfTest.sinceVersion()); | ||
| if (currentVersion.compareTo(testSinceVersion) >= 0) { |
There was a problem hiding this comment.
current version is last released version so it should not be equal to 0
|
SonarQube Quality Gate
|
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Overview
SNOW-XXXXX
External contributors - please answer these questions before submitting a pull request. Thanks!
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #NNNN
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.
Pre-review checklist