Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:only create tmp directory when compression is on. #767

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jfraleigh
Copy link

Description

Changed file_transfer_agent uploadOneFile method so that it only creates the tmp files when compression is on. Currently this code fails on the rmdir of the tmp directory because the directory is not empty. We do not utilize the compression feature and there is no need to create this directory. The documentation currently states: The driver uses this temporary directory to create temporary compressed files before uploading those files to Snowflake.

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@jfraleigh jfraleigh requested a review from a team as a code owner February 16, 2024 16:33
Copy link

github-actions bot commented Feb 16, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@jfraleigh
Copy link
Author

recheck

1 similar comment
@jfraleigh
Copy link
Author

recheck

@sfc-gh-pmotacki
Copy link
Collaborator

Hello @jfraleigh.I appreciate your contribution. I will run test on this PR and get back to you. Thank you.

@jfraleigh
Copy link
Author

Any movement on this PR?

Thanks

@jfraleigh
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants