Clear timeout if the brower action promise resolves before timeout

snowflakedb · Nov 21, 2024 · d40a3f4 · d40a3f4
1 parent c4e6edb
commit d40a3f4
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/lib/authentication/auth_web.js b/lib/authentication/auth_web.js
@@ -177,12 +177,15 @@ function AuthWeb(connectionConfig, httpClient, webbrowser) {
   }
 
   const withBrowserActionTimeout = (millis, promise) => {
+    let timeoutId;
+
     const timeout = new Promise((resolve, reject) =>
-      setTimeout(
+      timeoutId = setTimeout(
         () => reject(`Browser action timed out after ${browserActionTimeout} ms.`),
         millis));
+
     return Promise.race([
-      promise,
+      promise.finally(() => clearTimeout(timeoutId)),
       timeout
     ]);
   };